Add Dart_IsExternalString and Dart_ExternalStringGetPeer to the dart

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/assert.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
 #include "vm/unit_test.h"
@@ skipping 336 matching lines @@
     result = Dart_ListGetAt(val, i);
     EXPECT_VALID(result);
     int64_t value;
     result = Dart_IntegerValue(result, &value);
     EXPECT_VALID(result);
     EXPECT_EQ(i, value);
   }
 }
 
 
 UNIT_TEST_CASE(IsString) {

[siva, 2011/12/02 01:53:01]

I am wondering why many of the tests in this file don't use TEST_CASE instead of
UNIT_TEST_CASE as they seem to right away create an Isolate. Not for this change
list but maybe we could look at that possibility later.

[turnidge, 2011/12/05 17:54:28]

True.  Yes.

   TestIsolateScope __test_isolate__;
 
   uint8_t data8[] = { 'o', 'n', 'e', 0xFF };
 
   Dart_Handle str8 = Dart_NewString8(data8, ARRAY_SIZE(data8));
   EXPECT_VALID(str8);
   EXPECT(Dart_IsString(str8));
   EXPECT(Dart_IsString8(str8));
   EXPECT(Dart_IsString16(str8));
+  EXPECT(!Dart_IsExternalString(str8));
 
   Dart_Handle ext8 = Dart_NewExternalString8(data8, ARRAY_SIZE(data8),
                                              NULL, NULL);
   EXPECT_VALID(ext8);
   EXPECT(Dart_IsString(ext8));
   EXPECT(Dart_IsString8(ext8));
   EXPECT(Dart_IsString16(ext8));
+  EXPECT(Dart_IsExternalString(ext8));
 
   uint16_t data16[] = { 't', 'w', 'o', 0xFFFF };
 
   Dart_Handle str16 = Dart_NewString16(data16, ARRAY_SIZE(data16));
   EXPECT_VALID(str16);
   EXPECT(Dart_IsString(str16));
   EXPECT(!Dart_IsString8(str16));
   EXPECT(Dart_IsString16(str16));
+  EXPECT(!Dart_IsExternalString(str16));
 
   Dart_Handle ext16 = Dart_NewExternalString16(data16, ARRAY_SIZE(data16),
                                                NULL, NULL);
   EXPECT_VALID(ext16);
   EXPECT(Dart_IsString(ext16));
   EXPECT(!Dart_IsString8(ext16));
   EXPECT(Dart_IsString16(ext16));
+  EXPECT(Dart_IsExternalString(ext16));
 
   uint32_t data32[] = { 'f', 'o', 'u', 'r', 0x10FFFF };
 
   Dart_Handle str32 = Dart_NewString32(data32, ARRAY_SIZE(data32));
   EXPECT_VALID(str32);
   EXPECT(Dart_IsString(str32));
   EXPECT(!Dart_IsString8(str32));
   EXPECT(!Dart_IsString16(str32));
+  EXPECT(!Dart_IsExternalString(str32));
 
   Dart_Handle ext32 = Dart_NewExternalString32(data32, ARRAY_SIZE(data32),
                                                NULL, NULL);
   EXPECT_VALID(ext32);
   EXPECT(Dart_IsString(ext32));
   EXPECT(!Dart_IsString8(ext32));
   EXPECT(!Dart_IsString16(ext32));
+  EXPECT(Dart_IsExternalString(ext32));
+}
+
+
+UNIT_TEST_CASE(ExternalStringGetPeer) {
+  TestIsolateScope __test_isolate__;
+  Dart_Handle result;
+
+  uint8_t data8[] = { 'o', 'n', 'e', 0xFF };
+  int peer_data = 123;
+  void* peer = NULL;
+
+  // Success.
+  Dart_Handle ext8 = Dart_NewExternalString8(data8, ARRAY_SIZE(data8),
+                                             &peer_data, NULL);
+  EXPECT_VALID(ext8);
+
+  result = Dart_ExternalStringGetPeer(ext8, &peer);
+  EXPECT_VALID(result);
+  EXPECT_EQ(&peer_data, peer);
+
+  // NULL peer

[siva, 2011/12/02 01:53:01]

missing '.'

[turnidge, 2011/12/05 17:54:28]

Fixed.

+  result = Dart_ExternalStringGetPeer(ext8, NULL);
+  EXPECT(Dart_IsError(result));
+  EXPECT_STREQ("Dart_ExternalStringGetPeer expects argument 'peer' to be "
+               "non-NULL.", Dart_GetError(result));
+
+  // String is not external.
+  peer = NULL;
+  Dart_Handle str8 = Dart_NewString8(data8, ARRAY_SIZE(data8));
+  EXPECT_VALID(str8);
+  result = Dart_ExternalStringGetPeer(str8, &peer);
+  EXPECT(Dart_IsError(result));
+  EXPECT_STREQ("Dart_ExternalStringGetPeer expects argument 'object' to be "
+               "an external String.", Dart_GetError(result));
+  EXPECT(peer == NULL);
+
+  // Not a String.
+  peer = NULL;
+  result = Dart_ExternalStringGetPeer(Dart_True(), &peer);
+  EXPECT(Dart_IsError(result));
+  EXPECT_STREQ("Dart_ExternalStringGetPeer expects argument 'object' to be "
+               "of type String.", Dart_GetError(result));
+  EXPECT(peer == NULL);
 }
 
 
 #if defined(TARGET_ARCH_IA32)  // only ia32 can run execution tests.
 
 UNIT_TEST_CASE(ListAccess) {
   const char* kScriptChars =
       "class ListAccessTest {"
       "  ListAccessTest() {}"
       "  static List testMain() {"
@@ skipping 2293 matching lines @@
 }
 
 
 UNIT_TEST_CASE(RunLoop_Exception) {
   RunLoopTest(true);
 }
 
 #endif  // TARGET_ARCH_IA32.
 
 }  // namespace dart