Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 8775030: Update grit-i18n to r8 and remove \n workaround. (Closed)

Created:
9 years ago by tony
Modified:
9 years ago
Reviewers:
mmenke, Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Update grit-i18n to r8 and remove \n workaround. r8: No longer replace the string "\n" with a new line in messages. BUG=105985 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tony
9 years ago (2011-12-01 22:58:21 UTC) #1
mmenke
lgtm
9 years ago (2011-12-01 23:00:12 UTC) #2
Jói
LGTM On Thu, Dec 1, 2011 at 11:00 PM, <mmenke@chromium.org> wrote: > lgtm > > ...
9 years ago (2011-12-01 23:02:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/8775030/1
9 years ago (2011-12-01 23:03:38 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-02 00:29:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/8775030/1
9 years ago (2011-12-02 00:31:43 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-02 02:39:00 UTC) #7
Change committed as 112618

Powered by Google App Engine
This is Rietveld 408576698