Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons

Issue 8775028: Disable pdf test for pnacl for now. It relies on a private interface, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons
diff --git a/ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons b/ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons
index 6768fbaed0c379e996de90f122e403037aca7302..a1337ba38b8a8af0d92f8cff0edda716758493a3 100644
--- a/ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons
+++ b/ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons
@@ -36,4 +36,10 @@ node = env.PPAPIBrowserTester('ppapi_ppb_pdf_browser_test.out',
env.AddNodeToTestSuite(node,
['chrome_browser_tests'],
'run_ppapi_ppb_pdf_browser_test',
- is_broken=env.PPAPIBrowserTesterIsBroken())
+ # Pnacl x86-64 requires a shim. However the shim
+ # is generated via IDL, and pdf header is not
+ # generated via IDL right now
+ # http://code.google.com/p/chromium/issues/detail?id=89968
+ is_broken=(
+ env.PPAPIBrowserTesterIsBroken() or
+ (env.Bit('bitcode') and env.Bit('target_x86_64'))))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698