Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/ui/panels/panel_browser_window_cocoa.mm

Issue 8775022: Add Panel::SetPanelBoundsInstantly for all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_window_cocoa.mm
diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm
index 64a9224b6b91c83c3ede9b80d9f15a5bef249576..43bd1b8ca7be88472fc8027836348ffa32902c4c 100644
--- a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm
+++ b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm
@@ -109,7 +109,17 @@ void PanelBrowserWindowCocoa::SetPanelBounds(const gfx::Rect& bounds) {
bounds_ = bounds;
NSRect frame = ConvertCoordinatesToCocoa(bounds);
- [controller_ setPanelFrame:frame];
+ [controller_ setPanelFrame:frame animate:true];
Dmitry Titov 2011/12/01 20:52:50 should be animate:YES in Obj-C code
+}
+
+void PanelBrowserWindowCocoa::SetPanelBoundsInstantly(const gfx::Rect& bounds) {
jennb 2011/12/01 20:52:37 Could you use the same pattern here as you did for
+ if (bounds_ == bounds)
+ return;
+
+ bounds_ = bounds;
+
+ NSRect frame = ConvertCoordinatesToCocoa(bounds);
+ [controller_ setPanelFrame:frame animate:false];
Dmitry Titov 2011/12/01 20:52:50 animate:NO
}
void PanelBrowserWindowCocoa::ClosePanel() {

Powered by Google App Engine
This is Rietveld 408576698