Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5496)

Unified Diff: chrome/browser/ui/panels/panel_browser_window_cocoa.mm

Issue 8775022: Add Panel::SetPanelBoundsInstantly for all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_window_cocoa.mm
diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm
index dd8bff2ab72f123216e155f5c481fe30ec1556cb..ba84b09dfb6e3578cac2983ef0177054de45f4cd 100644
--- a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm
+++ b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm
@@ -103,13 +103,22 @@ gfx::Rect PanelBrowserWindowCocoa::GetPanelBounds() const {
// |bounds| is the platform-independent screen coordinates, with (0,0) at
// top-left of the primary screen.
void PanelBrowserWindowCocoa::SetPanelBounds(const gfx::Rect& bounds) {
+ setBoundsInternal(bounds, true);
+}
+
+void PanelBrowserWindowCocoa::SetPanelBoundsInstantly(const gfx::Rect& bounds) {
+ setBoundsInternal(bounds, false);
+}
+
+void PanelBrowserWindowCocoa::setBoundsInternal(const gfx::Rect& bounds,
+ bool animate) {
if (bounds_ == bounds)
return;
bounds_ = bounds;
NSRect frame = ConvertCoordinatesToCocoa(bounds);
- [controller_ setPanelFrame:frame];
+ [controller_ setPanelFrame:frame animate:animate];
}
void PanelBrowserWindowCocoa::ClosePanel() {

Powered by Google App Engine
This is Rietveld 408576698