Add Panel::SetPanelBoundsInstantly for all platforms.

chrome/browser/ui/panels/panel.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel.h"
 
 #include "base/logging.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 48 matching lines @@
 }
 
 PanelManager* Panel::manager() const {
   return PanelManager::GetInstance();
 }
 
 const Extension* Panel::GetExtension() const {
   return GetExtensionFromBrowser(browser());
 }
 
-void Panel::SetPanelBounds(const gfx::Rect& bounds) {
+void Panel::SetPanelBounds(const gfx::Rect& bounds, bool animate) {
   if (expansion_state_ == Panel::EXPANDED)
     restored_size_ = bounds.size();
 
-  native_panel_->SetPanelBounds(bounds);
+  native_panel_->SetPanelBounds(bounds, animate);
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PANEL_CHANGED_BOUNDS,
       content::Source<Panel>(this),
       content::NotificationService::NoDetails());
 }
 
 void Panel::SetAutoResizable(bool resizable) {
   if (auto_resizable_ == resizable)
     return;
@@ skipping 45 matching lines @@
     default:
       NOTREACHED();
       height = restored_size_.height();
       break;
   }
 
   int bottom = manager()->GetBottomPositionForExpansionState(expansion_state_);
   gfx::Rect bounds = native_panel_->GetPanelBounds();
   bounds.set_y(bottom - height);
   bounds.set_height(height);
-  SetPanelBounds(bounds);
+  SetPanelBounds(bounds, true);  // use animation.

[Dmitry Titov, 2011/12/01 19:59:51]

We tend to do enums instead of bools if callsites have to pass literal value -
because at callsite, it's not clear what 'true' means w/o lookup at the method
signature.

Could you change it to enum? Or even better, have NativePanel::SetPanelBounds()
with existing semantics (animated) and new NativePanel::SetPanelBoundsInstant().

[jianli, 2011/12/01 20:24:08]

Done.

 
   manager()->OnPanelExpansionStateChanged(old_state, new_state);
 
   // The minimized panel should not get the focus.
   if (expansion_state_ == MINIMIZED)
     Deactivate();
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PANEL_CHANGED_EXPANSION_STATE,
       content::Source<Panel>(this),
@@ skipping 485 matching lines @@
   if (auto_resizable_) {
     RenderViewHost* render_view_host = GetRenderViewHost();
     if (render_view_host)
       RequestRenderViewHostToDisableScrollbars(render_view_host);
   }
 }
 
 void Panel::DestroyBrowser() {
   native_panel_->DestroyPanelBrowser();
 }