Fix race condition disconnecting hosts.

Fix race condition disconnecting hosts.

Also, remove a couple of unused functions and rename some to be more meaningful following the recent refactoring.

BUG=102441
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112762

[Sergey Ulanov, 2011-12-01 20:35:24]

I don't think this is the right solution for the problem - there is a lot of
timing-dependent activity on the network thread and it is not desirable to block
this thread for any significant amount of time.
Another problem with this fix is that when the host plugin is being shut down
you cannot run any new tasks on the UI thread. We actually block UI thread
waiting for the host to shutdown on the network thread (it is needed because
plugin shutdown needs to be completed synchronously).

The actual bug is that LocalInputMonitor implementations don't increase
ref-count for ChromotingHost (i.e. they don't use scoped_refptr<>) and store raw
pointer to the host instead. This allows ChromotingHost to die while  input
monitors still reference it. So the right fix for this bug is to make sure that
all LocalInputMonitors use scoped_refptr<> to reference ChromotingHost.

http://codereview.chromium.org/8775021/diff/1/remoting/host/it2me_host_user_i...
File remoting/host/it2me_host_user_interface.cc (right):

http://codereview.chromium.org/8775021/diff/1/remoting/host/it2me_host_user_i...
remoting/host/it2me_host_user_interface.cc:82:
CHECK(callback_complete_.TimedWait(base::TimeDelta::FromSeconds(10)));
I don't think that blocking network thread on the UI thread is the right thing
to do.

[Jamie, 2011-12-01 20:54:44]

Fair point. ptal

[Sergey Ulanov, 2011-12-01 21:14:16]

lgtm

http://codereview.chromium.org/8775021/diff/3002/remoting/host/it2me_host_use...
File remoting/host/it2me_host_user_interface.cc (right):

http://codereview.chromium.org/8775021/diff/3002/remoting/host/it2me_host_use...
remoting/host/it2me_host_user_interface.cc:71: username));
nit: this parameter can be moved to the previous line.

[commit-bot: I haz the power, 2011-12-01 23:39:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/8775021/3002

[commit-bot: I haz the power, 2011-12-02 02:06:54]

Try job failure for 8775021-3002 (previous was lost) (retry) (retry) on win_rel
for step "update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-12-02 02:15:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/8775021/3002

[commit-bot: I haz the power, 2011-12-02 03:11:11]

Try job failure for 8775021-3002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-12-02 18:07:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/8775021/3002

[commit-bot: I haz the power, 2011-12-02 19:39:43]

Change committed as 112762