Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier.cc

Issue 8775018: Fix error logging in phishing_classifier.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/phishing_classifier.cc
diff --git a/chrome/renderer/safe_browsing/phishing_classifier.cc b/chrome/renderer/safe_browsing/phishing_classifier.cc
index 3cc51941e2218fad041ffde9f9d78b9816be1c02..f4545492466dfed8670759f6c6029d1723e10561 100644
--- a/chrome/renderer/safe_browsing/phishing_classifier.cc
+++ b/chrome/renderer/safe_browsing/phishing_classifier.cc
@@ -209,7 +209,7 @@ void PhishingClassifier::TermExtractionFinished(bool success) {
void PhishingClassifier::CheckNoPendingClassification() {
DCHECK(done_callback_.is_null());
DCHECK(!page_text_);
- if (done_callback_.is_null() || page_text_) {
+ if (!done_callback_.is_null() || page_text_) {
LOG(ERROR) << "Classification in progress, missing call to "
<< "CancelPendingClassification";
UMA_HISTOGRAM_COUNTS("SBClientPhishing.CheckNoPendingClassificationFailed",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698