Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 8775014: Remove IOThread::message_loop(). (Closed)

Created:
9 years ago by Jói
Modified:
9 years ago
Reviewers:
jam, battre
CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove IOThread::message_loop(). Instead introduce BrowserThread::UnsafeGetMessageLoop which is used in a couple of places. This will be removed in a follow-up change. I could have used UnsafeGetBrowserThread(id)->message_loop() but this is even easier to search for. Also, remove a couple of BrowserProcess accessors that aren't used by anybody, and that were using UnsafeGetBrowserThread. TBR=battre@chromium.org BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112697

Patch Set 1 #

Patch Set 2 : Remove base/ file from this change. #

Patch Set 3 : Merge to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -51 lines) Patch
M chrome/browser/browser_process.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/io_thread.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_linux.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/browser_thread.h View 3 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jói
9 years ago (2011-12-01 15:57:36 UTC) #1
Jói
On 2011/12/01 15:57:36, Jói wrote: FYI, I removed the base/ file that was in this ...
9 years ago (2011-12-01 17:48:07 UTC) #2
jam
lgtm
9 years ago (2011-12-01 19:16:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8775014/2013
9 years ago (2011-12-02 13:25:22 UTC) #4
commit-bot: I haz the power
Presubmit check for 8775014-2013 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-02 13:25:27 UTC) #5
Jói
TBR battre@ for trivial change in chrome/browser/net.
9 years ago (2011-12-02 13:27:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8775014/2013
9 years ago (2011-12-02 13:27:12 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-02 14:47:45 UTC) #8
Change committed as 112697

Powered by Google App Engine
This is Rietveld 408576698