Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8775013: [cros] Refresh all localized content on image screen. (Closed)

Created:
9 years ago by Nikita (slow)
Modified:
9 years ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org
Visibility:
Public.

Description

[cros] Refresh all localized content on image screen. BUG=chromium-os:23642 TEST=None. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112676

Patch Set 1 #

Total comments: 2

Patch Set 2 : refactor #

Patch Set 3 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.js View 1 2 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
9 years ago (2011-12-01 15:50:55 UTC) #1
Ivan Korotkov
http://codereview.chromium.org/8775013/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right): http://codereview.chromium.org/8775013/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js#newcode328 chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:328: updateLocalizedContent: function() { Can we eliminate the duplication be ...
9 years ago (2011-12-01 17:59:50 UTC) #2
Nikita (slow)
http://codereview.chromium.org/8775013/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right): http://codereview.chromium.org/8775013/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js#newcode328 chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:328: updateLocalizedContent: function() { On 2011/12/01 17:59:50, Ivan Korotkov wrote: ...
9 years ago (2011-12-02 10:06:35 UTC) #3
Ivan Korotkov
9 years ago (2011-12-02 10:08:47 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698