Issue 8775005: Content settings: whitelist kExtensionScheme and kChromeInternalScheme on the renderer side.

Issue 8775005: Content settings: whitelist kExtensionScheme and kChromeInternalScheme on the renderer side. (Closed)

Created:
9 years ago by marja

Modified:
9 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Content settings: whitelist kExtensionScheme and kChromeInternalScheme on the renderer side. BUG=104700 TEST=ContentSettingsObserverTest.WhitelistedSchemes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112665

Patch Set 1 #

Patch Set 2 : Refactoring + tests. #

Patch Set 3 : More tests #

Total comments: 4

Patch Set 4 : Code review. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -26 lines)			Patch
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/content_settings_observer.h	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/renderer/content_settings_observer.cc	View	1	2 chunks	+36 lines, -26 lines	0 comments	Download
A	chrome/renderer/content_settings_observer_unittest.cc	View	1 2 3	1 chunk	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

what about a test? e.g. in chrome/renderer/content_settings_observer_browsertest.cc

9 years ago (2011-12-01 12:52:46 UTC) #2

jochen (gone - plz use gerrit)

LGTM with nits http://codereview.chromium.org/8775005/diff/4001/chrome/renderer/content_settings_observer_unittest.cc File chrome/renderer/content_settings_observer_unittest.cc (right): http://codereview.chromium.org/8775005/diff/4001/chrome/renderer/content_settings_observer_unittest.cc#newcode15 chrome/renderer/content_settings_observer_unittest.cc:15: class ContentSettingsObserverTest : public testing::Test {}; ...

9 years ago (2011-12-01 15:23:31 UTC) #4

marja

Thanks for review! http://codereview.chromium.org/8775005/diff/4001/chrome/renderer/content_settings_observer_unittest.cc File chrome/renderer/content_settings_observer_unittest.cc (right): http://codereview.chromium.org/8775005/diff/4001/chrome/renderer/content_settings_observer_unittest.cc#newcode15 chrome/renderer/content_settings_observer_unittest.cc:15: class ContentSettingsObserverTest : public testing::Test {}; ...

9 years ago (2011-12-01 15:41:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/8775005/4002

9 years ago (2011-12-02 08:23:21 UTC) #6

Change committed as 112665

Expand Messages | Collapse Messages