Issue 8775004: Geolocation InfoBar sometimes doesn't expire when navigating back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8775004: Geolocation InfoBar sometimes doesn't expire when navigating back. (Closed)

Created:
9 years ago by bulach

Modified:
9 years ago

Reviewers:
John Knottenbelt

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Geolocation InfoBar sometimes doesn't expire when navigating back. Implements GeolocationConfirmInfoBarDelegate::ShouldExpire so the infobar is removed when the back navigation is committed. BUG=106025 TEST=unit_tests: new GeolocationPermissionContextTests.InfoBarUsesCommittedEntry. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112463

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
	M	chrome/browser/geolocation/chrome_geolocation_permission_context.cc	View		5 chunks	+20 lines, -0 lines	0 comments	Download
	M	chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc	View		2 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/8775004/1

9 years ago (2011-12-01 13:56:37 UTC) #3

Change committed as 112463

Expand Messages | Collapse Messages