Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 8775002: Simplify stack check instruction in Crankshaft. (Closed)

Created:
9 years ago by fschneider
Modified:
9 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Simplify stack check instruction in Crankshaft. So far we had two types of stack checks: one used for function entries and one used at loop back edges which uses a deferred code object to avoid spilling of registers in the loop. After refactoring lazy deoptimization the first stack check can also use deferred code. This change removes the first type of stack check instruction in Crankshaft and uses a deferred stack check in all places. Committed: http://code.google.com/p/v8/source/detail?r=10118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -131 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +14 lines, -30 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +1 line, -12 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +15 lines, -35 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +13 lines, -28 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years ago (2011-12-01 09:44:28 UTC) #1
Jakob Kummerow
9 years ago (2011-12-01 09:51:54 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698