Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8774050: Pass along the referrer policy (renderer side) (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)
Modified:
9 years ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., ajwong+watch_chromium.org
Visibility:
Public.

Description

Pass along the referrer policy (renderer side) BUG=105028 TEST=none (browser side still missing, does nothing yet) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112898

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : updates #

Total comments: 2

Patch Set 4 : updates #

Patch Set 5 : rebase #

Patch Set 6 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -46 lines) Patch
M chrome/browser/external_tab_container_win.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 6 chunks +10 lines, -3 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/frame_navigate_params.h View 2 chunks +2 lines, -1 line 0 comments Download
A content/public/common/referrer.h View 1 chunk +31 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 16 chunks +49 lines, -22 lines 0 comments Download
M webkit/glue/context_menu.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/glue/context_menu.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jochen (gone - plz use gerrit)
John, can you please review content/public/common/referrer.h (that's the same class you already reviewed a while ...
9 years ago (2011-12-02 19:20:53 UTC) #1
jam
content/public lgtm
9 years ago (2011-12-02 20:43:00 UTC) #2
darin (slow to review)
http://codereview.chromium.org/8774050/diff/4001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/8774050/diff/4001/content/renderer/render_view_impl.cc#newcode2311 content/renderer/render_view_impl.cc:2311: from, ds ? getReferrerPolicyFromRequest(ds->request()) : if the provisionalDataSource is ...
9 years ago (2011-12-02 22:22:40 UTC) #3
jochen (gone - plz use gerrit)
http://codereview.chromium.org/8774050/diff/4001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/8774050/diff/4001/content/renderer/render_view_impl.cc#newcode2311 content/renderer/render_view_impl.cc:2311: from, ds ? getReferrerPolicyFromRequest(ds->request()) : On 2011/12/02 22:22:40, darin ...
9 years ago (2011-12-02 22:24:39 UTC) #4
darin (slow to review)
OK, LGTM for content/renderer/*
9 years ago (2011-12-02 22:26:42 UTC) #5
darin (slow to review)
LGTM for webkit/glue too
9 years ago (2011-12-02 22:38:03 UTC) #6
jam
lgtm for the rest
9 years ago (2011-12-02 22:53:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8774050/4003
9 years ago (2011-12-02 23:45:48 UTC) #8
commit-bot: I haz the power
Can't apply patch for file content/browser/tab_contents/tab_contents.cc. While running patch -p1 --forward --force; patching file content/browser/tab_contents/tab_contents.cc ...
9 years ago (2011-12-03 03:16:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8774050/6011
9 years ago (2011-12-03 19:09:58 UTC) #10
commit-bot: I haz the power
9 years ago (2011-12-03 21:03:17 UTC) #11 
Change committed as 112898

Powered by Google App Engine
This is Rietveld 408576698