Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2572)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/nacl_host/nacl_process_host.h

Issue 8774040: Don't make classes derive from ChildProcessHost, and instead have them use it through composition... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix linker errors on posix Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/nacl_host/nacl_broker_host_win.cc ('k') | chrome/browser/nacl_host/nacl_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/nacl_process_host.h
===================================================================
--- chrome/browser/nacl_host/nacl_process_host.h (revision 112722)
+++ chrome/browser/nacl_host/nacl_process_host.h (working copy)
@@ -43,7 +43,6 @@
protected:
virtual base::TerminationStatus GetChildTerminationStatus(
int* exit_code) OVERRIDE;
- virtual void OnChildDied() OVERRIDE;
private:
// Internal class that holds the nacl::Handle objecs so that
@@ -59,8 +58,6 @@
void IrtReady();
void SendStart(base::PlatformFile irt_file);
- virtual bool CanShutdown() OVERRIDE;
-
private:
// The ChromeRenderMessageFilter that requested this NaCl process. We use
// this for sending the reply once the process has started.
« no previous file with comments | « chrome/browser/nacl_host/nacl_broker_host_win.cc ('k') | chrome/browser/nacl_host/nacl_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698