Don't make classes derive from ChildProcessHost, and instead have them use it through composition...

content/common/child_process_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/child_process_host.h"
 
 #include <limits>
 
 #include "base/atomicops.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/rand_util.h"
 #include "base/stringprintf.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "content/common/child_process_messages.h"
+#include "content/public/common/child_process_host_delegate.h"
 #include "content/public/common/content_paths.h"
 #include "content/public/common/content_switches.h"
 #include "ipc/ipc_logging.h"
 
 #if defined(OS_LINUX)
 #include "base/linux_util.h"
 #elif defined(OS_WIN)
 #include "content/common/font_cache_dispatcher_win.h"
 #endif  // OS_LINUX
 
@@ skipping 36 matching lines @@
                                .Append(kContentsName)
                                .Append(kMacOSName)
                                .Append(new_basename);
 
   return new_path;
 }
 
 }  // namespace
 #endif  // OS_MACOSX
 
-ChildProcessHost::ChildProcessHost()
-    : ALLOW_THIS_IN_INITIALIZER_LIST(listener_(this)),
+ChildProcessHost::ChildProcessHost(content::ChildProcessHostDelegate* delegate)
+    : delegate_(delegate),
+      peer_handle_(base::kNullProcessHandle),
       opening_channel_(false) {
 #if defined(OS_WIN)
   AddFilter(new FontCacheDispatcher());
 #endif
 }
 
 ChildProcessHost::~ChildProcessHost() {
   for (size_t i = 0; i < filters_.size(); ++i) {
     filters_[i]->OnChannelClosing();
     filters_[i]->OnFilterRemoved();
   }
-  listener_.Shutdown();
+
+  base::CloseProcessHandle(peer_handle_);
 }
 
 void ChildProcessHost::AddFilter(IPC::ChannelProxy::MessageFilter* filter) {
   filters_.push_back(filter);
 
   if (channel_.get())
     filter->OnFilterAdded(channel_.get());
 }
 
 // static
@@ skipping 40 matching lines @@
   return child_path;
 }
 
 void ChildProcessHost::ForceShutdown() {
   Send(new ChildProcessMsg_Shutdown());
 }
 
 bool ChildProcessHost::CreateChannel() {
   channel_id_ = GenerateRandomChannelID(this);
   channel_.reset(new IPC::Channel(
-      channel_id_, IPC::Channel::MODE_SERVER, &listener_));
+      channel_id_, IPC::Channel::MODE_SERVER, this));
   if (!channel_->Connect())
     return false;
 
   for (size_t i = 0; i < filters_.size(); ++i)
     filters_[i]->OnFilterAdded(channel_.get());
 
   // Make sure these messages get sent first.
 #if defined(IPC_MESSAGE_LOG_ENABLED)
   bool enabled = IPC::Logging::GetInstance()->Enabled();
   Send(new ChildProcessMsg_SetIPCLoggingEnabled(enabled));
 #endif
 
   Send(new ChildProcessMsg_AskBeforeShutdown());
 
   opening_channel_ = true;
 
   return true;
 }
 
-bool ChildProcessHost::OnMessageReceived(const IPC::Message& msg) {
-  return false;
-}
-
-void ChildProcessHost::OnChannelConnected(int32 peer_pid) {
-}
-
-void ChildProcessHost::OnChannelError() {
-}
-
 bool ChildProcessHost::Send(IPC::Message* message) {
   if (!channel_.get()) {
     delete message;
     return false;
   }
   return channel_->Send(message);
 }
 
-void ChildProcessHost::OnAllocateSharedMemory(
+void ChildProcessHost::AllocateSharedMemory(
       uint32 buffer_size, base::ProcessHandle child_process_handle,
       base::SharedMemoryHandle* shared_memory_handle) {
   base::SharedMemory shared_buf;
   if (!shared_buf.CreateAndMapAnonymous(buffer_size)) {
     *shared_memory_handle = base::SharedMemory::NULLHandle();
     NOTREACHED() << "Cannot map shared memory buffer";
     return;
   }
   shared_buf.GiveToProcess(child_process_handle, shared_memory_handle);
 }
 
 std::string ChildProcessHost::GenerateRandomChannelID(void* instance) {
   // Note: the string must start with the current process id, this is how
   // child processes determine the pid of the parent.
   // Build the channel ID.  This is composed of a unique identifier for the
   // parent browser process, an identifier for the child instance, and a random
   // component. We use a random component so that a hacked child process can't
   // cause denial of service by causing future named pipe creation to fail.
   return base::StringPrintf("%d.%p.%d",
                             base::GetCurrentProcId(), instance,
                             base::RandInt(0, std::numeric_limits<int>::max()));
 }
 
 int ChildProcessHost::GenerateChildProcessUniqueId() {
   // This function must be threadsafe.
   static base::subtle::Atomic32 last_unique_child_id = 0;
   return base::subtle::NoBarrier_AtomicIncrement(&last_unique_child_id, 1);
 }
 
-
-void ChildProcessHost::OnChildDied() {
-  delete this;
-}
-
-void ChildProcessHost::OnChildDisconnected() {
-  OnChildDied();
-}
-
-void ChildProcessHost::ShutdownStarted() {
-}
-
-ChildProcessHost::ListenerHook::ListenerHook(ChildProcessHost* host)
-    : host_(host), peer_handle_(base::kNullProcessHandle) {
-}
-
-ChildProcessHost::ListenerHook::~ListenerHook() {
-  base::CloseProcessHandle(peer_handle_);
-}
-
-void ChildProcessHost::ListenerHook::Shutdown() {
-  host_ = NULL;
-}
-
-bool ChildProcessHost::ListenerHook::OnMessageReceived(
-    const IPC::Message& msg) {
-  if (!host_)
-    return true;
-
+bool ChildProcessHost::OnMessageReceived(const IPC::Message& msg) {
 #ifdef IPC_MESSAGE_LOG_ENABLED
   IPC::Logging* logger = IPC::Logging::GetInstance();
   if (msg.type() == IPC_LOGGING_ID) {
     logger->OnReceivedLoggingMessage(msg);
     return true;
   }
 
   if (logger->Enabled())
     logger->OnPreDispatchMessage(msg);
 #endif
 
   bool handled = false;
-  for (size_t i = 0; i < host_->filters_.size(); ++i) {
-    if (host_->filters_[i]->OnMessageReceived(msg)) {
+  for (size_t i = 0; i < filters_.size(); ++i) {
+    if (filters_[i]->OnMessageReceived(msg)) {
       handled = true;
       break;
     }
   }
 
   if (!handled) {
-    bool msg_is_good = false;
     handled = true;
-    IPC_BEGIN_MESSAGE_MAP_EX(ListenerHook, msg, msg_is_good)
+    IPC_BEGIN_MESSAGE_MAP(ChildProcessHost, msg)
       IPC_MESSAGE_HANDLER(ChildProcessHostMsg_ShutdownRequest,
                           OnShutdownRequest)
       IPC_MESSAGE_HANDLER(ChildProcessHostMsg_SyncAllocateSharedMemory,
                           OnAllocateSharedMemory)
       IPC_MESSAGE_UNHANDLED(handled = false)
-    IPC_END_MESSAGE_MAP_EX()
+    IPC_END_MESSAGE_MAP()
 
     if (!handled)
-      handled = host_->OnMessageReceived(msg);
+      handled = delegate_->OnMessageReceived(msg);
   }
 
 #ifdef IPC_MESSAGE_LOG_ENABLED
   if (logger->Enabled())
-    logger->OnPostDispatchMessage(msg, host_->channel_id_);
+    logger->OnPostDispatchMessage(msg, channel_id_);
 #endif
   return handled;
 }
 
-void ChildProcessHost::ListenerHook::OnChannelConnected(int32 peer_pid) {
-  if (!host_)
-    return;
+void ChildProcessHost::OnChannelConnected(int32 peer_pid) {
   if (!base::OpenProcessHandle(peer_pid, &peer_handle_)) {
     NOTREACHED();
   }
-  host_->opening_channel_ = false;
-  host_->OnChannelConnected(peer_pid);
-  for (size_t i = 0; i < host_->filters_.size(); ++i)
-    host_->filters_[i]->OnChannelConnected(peer_pid);
+  opening_channel_ = false;
+  delegate_->OnChannelConnected(peer_pid);
+  for (size_t i = 0; i < filters_.size(); ++i)
+    filters_[i]->OnChannelConnected(peer_pid);
 }
 
-void ChildProcessHost::ListenerHook::OnChannelError() {
-  if (!host_)
-    return;
-  host_->opening_channel_ = false;
-  host_->OnChannelError();
+void ChildProcessHost::OnChannelError() {
+  opening_channel_ = false;
+  delegate_->OnChannelError();
 
-  for (size_t i = 0; i < host_->filters_.size(); ++i)
-    host_->filters_[i]->OnChannelError();
+  for (size_t i = 0; i < filters_.size(); ++i)
+    filters_[i]->OnChannelError();
 
   // This will delete host_, which will also destroy this!
-  host_->OnChildDisconnected();
+  delegate_->OnChildDisconnected();
 }
 
-bool ChildProcessHost::ListenerHook::Send(IPC::Message* message) {
-  return host_->Send(message);
+void ChildProcessHost::OnAllocateSharedMemory(
+    uint32 buffer_size,
+    base::SharedMemoryHandle* handle) {
+  AllocateSharedMemory(buffer_size, peer_handle_, handle);
 }
 
-void ChildProcessHost::ListenerHook::OnAllocateSharedMemory(
-    uint32 buffer_size,
-    base::SharedMemoryHandle* handle) {
-  ChildProcessHost::OnAllocateSharedMemory(
-      buffer_size, peer_handle_, handle);
+void ChildProcessHost::OnShutdownRequest() {
+  if (delegate_->CanShutdown())
+    Send(new ChildProcessMsg_Shutdown());
 }
-
-void ChildProcessHost::ListenerHook::OnShutdownRequest() {
-  if (host_->CanShutdown())
-    host_->Send(new ChildProcessMsg_Shutdown());
-}