Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 8774036: A build fix for gcc 4.5+. (Closed)

Created:
9 years ago by Hironori Bono
Modified:
9 years ago
CC:
chromium-reviews, Paweł Hajdan Jr., Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

A build fix for gcc 4.5+. GCC 4.5+ somehow causes compilation errors while compiling EXPECT_EQ(false,...) and EXPECT_EQ(true,...). This change just replaces EXPECT_EQ(false,...) with EXPECT_FALSE(...), and replaces EXPECT_EQ(true,...) with EXPECT_TRUE(...), respectively. BUG=none TEST=build unit_tests with gcc 4.5+ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/tab_contents/per_tab_prefs_tab_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hironori Bono
9 years ago (2011-12-02 05:07:28 UTC) #1
Avi (use Gerrit)
Code LGTM. Explanation is weird; they're not literals? The C++ standard ('98) says explicitly (§2.13.5, ...
9 years ago (2011-12-02 05:15:15 UTC) #2
Hironori Bono
Greetings Avi, Many thanks for your comment. Sorry, this description was quite confusing. I have ...
9 years ago (2011-12-02 05:42:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/8774036/1
9 years ago (2011-12-02 08:22:19 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-02 10:01:53 UTC) #5
Change committed as 112669

Powered by Google App Engine
This is Rietveld 408576698