Multi-step authentication support in JingleSession.

remoting/protocol/jingle_session_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop_proxy.h"
 #include "base/time.h"
 #include "base/test/test_timeouts.h"
 #include "net/socket/socket.h"
 #include "net/socket/stream_socket.h"
@@ skipping 167 matching lines @@
 
     EXPECT_CALL(host_server_listener_, OnIncomingSession(_, _))
         .WillOnce(DoAll(
             WithArg<0>(Invoke(
                 this, &JingleSessionTest::SetHostSession)),
             SetArgumentPointee<1>(protocol::SessionManager::ACCEPT)));
 
     {
       InSequence dummy;
 
+      EXPECT_CALL(host_connection_callback_,
+                  OnStateChange(Session::CONNECTED))
+          .Times(AtMost(1));
       if (expect_fail) {
         EXPECT_CALL(host_connection_callback_,
                     OnStateChange(Session::FAILED))
             .Times(1)
             .WillOnce(QuitThreadOnCounter(&not_connected_peers));
       } else {
         EXPECT_CALL(host_connection_callback_,
-                    OnStateChange(Session::CONNECTED))
-            .Times(1);
-        EXPECT_CALL(host_connection_callback_,
                     OnStateChange(Session::AUTHENTICATED))
             .Times(1)
             .WillOnce(QuitThreadOnCounter(&not_connected_peers));
         // Expect that the connection will be closed eventually.
         EXPECT_CALL(host_connection_callback_,
                     OnStateChange(Session::CLOSED))
             .Times(AtMost(1));
       }
     }
 
     {
       InSequence dummy;
 
       EXPECT_CALL(client_connection_callback_,
                   OnStateChange(Session::CONNECTING))
           .Times(1);
+      EXPECT_CALL(client_connection_callback_,
+                  OnStateChange(Session::CONNECTED))
+          .Times(AtMost(1));
       if (!expect_fail) {
         EXPECT_CALL(client_connection_callback_,
-                    OnStateChange(Session::CONNECTED))
-            .Times(1);
-        EXPECT_CALL(client_connection_callback_,
                     OnStateChange(Session::AUTHENTICATED))
             .Times(1)
             .WillOnce(QuitThreadOnCounter(&not_connected_peers));
       }
       // Expect that the connection will be closed eventually.
       EXPECT_CALL(client_connection_callback_,
                   OnStateChange(Session::CLOSED))
           .Times(AtMost(1));
     }
 
@@ skipping 114 matching lines @@
 
   ASSERT_TRUE(RunMessageLoopWithTimeout(TestTimeouts::action_max_timeout_ms()));
 }
 
 // Verify that we can connect two endpoints.
 TEST_F(JingleSessionTest, Connect) {
   CreateServerPair(FakeAuthenticator::ACCEPT, 1);
   ASSERT_TRUE(InitiateConnection(FakeAuthenticator::ACCEPT, 1, false));
 }
 
-// Verify that we can't connect two endpoints with mismatched secrets.
+// Verify that we can connect two endpoints with multi-step
+// authentication.

[Wez, 2011/12/03 00:21:05]

nit: premature line-wrap?

[Sergey Ulanov, 2011/12/06 19:37:07]

Done.

+TEST_F(JingleSessionTest, ConnectMultistep) {
+  CreateServerPair(FakeAuthenticator::ACCEPT, 3);
+  ASSERT_TRUE(InitiateConnection(FakeAuthenticator::ACCEPT, 3, false));
+}
+
+// Verify that connection is terminted when auth fails.
 TEST_F(JingleSessionTest, ConnectBadAuth) {
   CreateServerPair(FakeAuthenticator::REJECT, 1);
   ASSERT_TRUE(InitiateConnection(FakeAuthenticator::ACCEPT, 1, true));
 }
 
+// Verify that connection is terminted when multi-step auth fails.

[Wez, 2011/12/03 00:21:05]

nit: terminated

[Sergey Ulanov, 2011/12/06 19:37:07]

Done.

+TEST_F(JingleSessionTest, ConnectBadMultistepAuth) {
+  CreateServerPair(FakeAuthenticator::REJECT, 3);
+  ASSERT_TRUE(InitiateConnection(FakeAuthenticator::ACCEPT, 3, true));
+}
+
 TEST_F(JingleSessionTest, ConnectBadChannelAuth) {
   CreateServerPair(FakeAuthenticator::REJECT_CHANNEL, 1);
   ASSERT_TRUE(InitiateConnection(FakeAuthenticator::ACCEPT, 1, false));
 
   MockStreamChannelCallback client_callback;
   MockStreamChannelCallback host_callback;
 
   client_session_->CreateStreamChannel(kChannelName, base::Bind(
       &MockStreamChannelCallback::OnDone,
       base::Unretained(&client_callback)));
@@ skipping 20 matching lines @@
 
   ASSERT_TRUE(CreateChannel());
 
   StreamConnectionTester tester(host_socket_.get(), client_socket_.get(),
                                 kMessageSize, kMessages);
   tester.Start();
   message_loop_.Run();
   tester.CheckResults();
 }
 
+// Verify that we can connect channgels with multistep auth.

[Wez, 2011/12/03 00:21:05]

nit: channels

[Sergey Ulanov, 2011/12/06 19:37:07]

Done.

+TEST_F(JingleSessionTest, TestMultistepAuthTcpChannel) {
+  CreateServerPair(FakeAuthenticator::ACCEPT, 3);
+  ASSERT_TRUE(InitiateConnection(FakeAuthenticator::ACCEPT, 3, false));
+
+  ASSERT_TRUE(CreateChannel());
+
+  StreamConnectionTester tester(host_socket_.get(), client_socket_.get(),
+                                kMessageSize, kMessages);
+  tester.Start();
+  message_loop_.Run();
+  tester.CheckResults();
+}
+
 // Verify that data can be transmitted over the video RTP channel.
 TEST_F(JingleSessionTest, TestUdpChannel) {
   CreateServerPair(FakeAuthenticator::ACCEPT, 1);
   ASSERT_TRUE(InitiateConnection(FakeAuthenticator::ACCEPT, 1, false));
 
   MockDatagramChannelCallback client_callback;
   MockDatagramChannelCallback host_callback;
 
   int counter = 2;
   net::Socket* client_socket = NULL;
@@ skipping 33 matching lines @@
   CreateServerPair(FakeAuthenticator::ACCEPT, 1);
 
   RunSpeedTest(512);
   RunSpeedTest(1024);
   RunSpeedTest(51200);
   RunSpeedTest(512000);
 }
 
 }  // namespace protocol
 }  // namespace remoting