Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 8774026: Fix incorrect number in pyauto tests that caused them to fail with stricter versions of the phone... (Closed)

Created:
9 years ago by GeorgeY
Modified:
9 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, GeorgeY, dhollowa+watch_chromium.org, Ilya Sherman, dyu1, Paweł Hajdan Jr., Nirnimesh
Visibility:
Public.

Description

Fix incorrect number in pyauto tests that caused them to fail with stricter versions of the phonenumber library. BUG=none TEST=pyauto Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/autofill/functional/phonecharacters.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
GeorgeY
9 years ago (2011-12-02 00:14:51 UTC) #1
Ilya Sherman
LGTM, thanks
9 years ago (2011-12-02 00:21:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/georgey@chromium.org/8774026/1
9 years ago (2011-12-02 00:23:07 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-02 01:47:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/georgey@chromium.org/8774026/1
9 years ago (2011-12-02 01:55:36 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-02 03:38:46 UTC) #6
Change committed as 112629

Powered by Google App Engine
This is Rietveld 408576698