Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/ui/views/window.cc

Issue 8774022: Converting BubbleWindow uses, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Doesn't build... just a checkpoint for this work, might change approach. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/keyboard_overlay_dialog_view.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/window.h" 5 #include "chrome/browser/ui/views/window.h"
6 6
7 #include "ui/views/bubble/bubble_delegate.h" 7 #include "ui/views/bubble/bubble_delegate.h"
8 #include "ui/views/widget/widget.h" 8 #include "ui/views/widget/widget.h"
9 9
10 #if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK) 10 #if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
11 #include "chrome/browser/chromeos/frame/bubble_window.h"
12 #include "chrome/browser/chromeos/legacy_window_manager/wm_ipc.h" 11 #include "chrome/browser/chromeos/legacy_window_manager/wm_ipc.h"
13 #include "third_party/cros_system_api/window_manager/chromeos_wm_ipc_enums.h" 12 #include "third_party/cros_system_api/window_manager/chromeos_wm_ipc_enums.h"
14 #endif 13 #endif
15 14
16 namespace browser { 15 namespace browser {
17 16
18 views::Widget* CreateViewsWindow(gfx::NativeWindow parent, 17 views::Widget* CreateViewsWindow(gfx::NativeWindow parent,
19 views::WidgetDelegate* delegate, 18 views::WidgetDelegate* delegate,
20 DialogStyle style) { 19 DialogStyle style) {
21 #if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
22 // TODO(msw): revert to BubbleWindow for all ChromeOS cases when CL
23 // for crbug.com/98322 is landed.
24 return chromeos::BubbleWindow::Create(parent, style, delegate);
25 #else
26 return views::Widget::CreateWindowWithParent(delegate, parent); 20 return views::Widget::CreateWindowWithParent(delegate, parent);
27 #endif
28 } 21 }
29 22
30 views::Widget* CreateViewsBubble(views::BubbleDelegateView* delegate) { 23 views::Widget* CreateViewsBubble(views::BubbleDelegateView* delegate) {
31 views::Widget* bubble_widget = 24 views::Widget* bubble_widget =
32 views::BubbleDelegateView::CreateBubble(delegate); 25 views::BubbleDelegateView::CreateBubble(delegate);
33 #if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK) 26 #if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
34 { 27 {
35 std::vector<int> params; 28 std::vector<int> params;
36 params.push_back(0); // Do not show when screen is locked. 29 params.push_back(0); // Do not show when screen is locked.
37 chromeos::WmIpc::instance()->SetWindowType( 30 chromeos::WmIpc::instance()->SetWindowType(
(...skipping 14 matching lines...) Expand all
52 params.push_back(1); // Show while screen is locked. 45 params.push_back(1); // Show while screen is locked.
53 chromeos::WmIpc::instance()->SetWindowType( 46 chromeos::WmIpc::instance()->SetWindowType(
54 bubble_widget->GetNativeView(), 47 bubble_widget->GetNativeView(),
55 chromeos::WM_IPC_WINDOW_CHROME_INFO_BUBBLE, 48 chromeos::WM_IPC_WINDOW_CHROME_INFO_BUBBLE,
56 &params); 49 &params);
57 #endif 50 #endif
58 return bubble_widget; 51 return bubble_widget;
59 } 52 }
60 53
61 } // namespace browser 54 } // namespace browser
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/keyboard_overlay_dialog_view.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698