Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 8774016: Change the panel using the improved way of doing autosizing. (Closed)

Created:
9 years ago by levin
Modified:
9 years ago
Reviewers:
jennb
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, prasadt
Visibility:
Public.

Description

Change the panel using the improved way of doing autosizing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112792

Patch Set 1 #

Total comments: 1

Patch Set 2 : clean up. #

Patch Set 3 : fix bug #

Patch Set 4 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -51 lines) Patch
M chrome/browser/ui/panels/panel.h View 1 2 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 2 3 3 chunks +15 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jennb
LGTM http://codereview.chromium.org/8774016/diff/1/chrome/browser/ui/panels/panel.cc File chrome/browser/ui/panels/panel.cc (right): http://codereview.chromium.org/8774016/diff/1/chrome/browser/ui/panels/panel.cc#newcode618 chrome/browser/ui/panels/panel.cc:618: void Panel::EnableRendererAutoResize(RenderViewHost* render_view_host) { Only reason we had ...
9 years ago (2011-12-01 21:56:56 UTC) #1
levin
How's this?
9 years ago (2011-12-01 22:41:11 UTC) #2
levin
On 2011/12/01 22:41:11, levin wrote: > How's this? Comment from Jenn: "GetRenderViewHost() uses browser's GetSelectedTabContents. ...
9 years ago (2011-12-01 23:03:51 UTC) #3
levin
On 2011/12/01 23:03:51, levin wrote: > On 2011/12/01 22:41:11, levin wrote: > > How's this? ...
9 years ago (2011-12-01 23:29:25 UTC) #4
jennb
9 years ago (2011-12-01 23:46:31 UTC) #5
LGTM

Nice.

Powered by Google App Engine
This is Rietveld 408576698