Issue 8774014: ntp: don't care about changes to home page pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8774014: ntp: don't care about changes to home page pref (Closed)

Created:
9 years ago by Evan Stade

Modified:
9 years ago

Reviewers:
csilv, Dan Beam

CC:
chromium-reviews, estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ntp: don't care about changes to home page pref a long while back the NTP showed some sort of UI depending on whether it was your home page or not, but that's long since gone so we don't need to reconstruct the cache if it's changed. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112957

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8774014/1

9 years ago (2011-12-01 23:30:15 UTC) #5

commit-bot: I haz the power

Try job failure for 8774014-1 (retry) on win_rel for step "browser_tests". It's a second try, ...

9 years ago (2011-12-02 01:59:38 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8774014/1

9 years ago (2011-12-05 02:08:45 UTC) #7

Change committed as 112957

Expand Messages | Collapse Messages