Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 8774011: Fix syncing of oauth_client_id value for AppNotificationSettings (Closed)

Created:
9 years ago by asargent_no_longer_on_chrome
Modified:
9 years ago
Reviewers:
akalin
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), Paweł Hajdan Jr., Munjal (Google)
Visibility:
Public.

Description

Fix syncing of oauth_client_id value for AppNotificationSettings BUG=105682 TEST=covered by unit test, but not easy to manually test right now Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/sync/protocol/proto_value_conversions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions_unittest.cc View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
asargent_no_longer_on_chrome
I noticed this problem while doing some manual testing after landing http://codereview.chromium.org/8727024/ FYI, elvin is ...
9 years ago (2011-12-01 19:27:07 UTC) #1
asargent_no_longer_on_chrome
[changing reviewer to akalin]
9 years ago (2011-12-01 22:10:39 UTC) #2
akalin
LGTM
9 years ago (2011-12-01 22:12:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8774011/1
9 years ago (2011-12-01 22:27:38 UTC) #4
commit-bot: I haz the power
Try job failure for 8774011-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=3140 Step "update" is always ...
9 years ago (2011-12-01 22:32:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8774011/1
9 years ago (2011-12-01 22:40:34 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-02 02:23:24 UTC) #7
Change committed as 112603

Powered by Google App Engine
This is Rietveld 408576698