Preventing files from being resorted after load.

Preventing files from being resorted after load.

Scanning a directory we add files to the data model, sort them by name (if the sorting field needs async call like date) and then resort againg when data available.
To avoid flacking lets fetch the data before adding data to the model.

BUG=chromium-os:19082
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112691

[SeRya, 2011-12-01 18:20:57]

review please

[dgozman, 2011-12-02 09:33:41]

LGTM

Do not forget to add spinner.

http://codereview.chromium.org/8774008/diff/2001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/8774008/diff/2001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/file_manager.js:1494: if (field ==
'name' || field == 'cachedMtime_') {
We do not have two files with the same name. Let's do not fetch Mtime.

http://codereview.chromium.org/8774008/diff/2001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/file_manager.js:3223:
self.prefetchCacheForSorting_(entries, function() {
entries -> spliceArgs

[SeRya, 2011-12-02 12:32:21]

http://codereview.chromium.org/8774008/diff/2001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/8774008/diff/2001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/file_manager.js:1494: if (field ==
'name' || field == 'cachedMtime_') {
On 2011/12/02 09:33:41, dgozman wrote:
> We do not have two files with the same name. Let's do not fetch Mtime.

I'm not sure it need to be fixed. At least not in this CL.

http://codereview.chromium.org/8774008/diff/2001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/file_manager.js:3223:
self.prefetchCacheForSorting_(entries, function() {
On 2011/12/02 09:33:41, dgozman wrote:
> entries -> spliceArgs

Done.

[commit-bot: I haz the power, 2011-12-02 12:32:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/8774008/1004

[commit-bot: I haz the power, 2011-12-02 14:10:04]

Change committed as 112691