Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4724)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 8773046: [cros] Display emails of users are stored in a separate dictionary in Local State. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index 97c00d803c6077ad20c66e31eb757ee52193a865..227ca7b3701ba9a0eaf177f87ca2362ac4d17348 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -52,8 +52,10 @@ const char kGaiaExtStartPage[] =
"chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/main.html";
// User dictionary keys.
-const char kKeyName[] = "name";
+const char kKeyUsername[] = "username";
+const char kKeyDisplayName[] = "displayName";
const char kKeyEmailAddress[] = "emailAddress";
+const char kKeyNameTooltip[] = "nameTooltip";
const char kKeySignedIn[] = "signedIn";
const char kKeyCanRemove[] = "canRemove";
const char kKeyOauthTokenStatus[] = "oauthTokenStatus";
@@ -532,6 +534,7 @@ void SigninScreenHandler::HandleCompleteLogin(const base::ListValue* args) {
}
username = SanitizeEmail(username);
+ delegate_->SetDisplayEmail(username);
delegate_->CompleteLogin(username, password);
}
@@ -623,8 +626,11 @@ void SigninScreenHandler::SendUserList(bool animated) {
if (non_owner_count < max_non_owner_users || is_owner) {
DictionaryValue* user_dict = new DictionaryValue();
- user_dict->SetString(kKeyName, (*it)->GetDisplayName());
- user_dict->SetString(kKeyEmailAddress, email);
+ user_dict->SetString(kKeyUsername, email);
+ user_dict->SetString(kKeyEmailAddress, (*it)->display_email());
+ user_dict->SetString(kKeyDisplayName, (*it)->GetDisplayName());
+ if ((*it)->NeedsNameTooltip())
+ user_dict->SetString(kKeyNameTooltip, (*it)->GetNameTooltip());
user_dict->SetInteger(kKeyOauthTokenStatus, (*it)->oauth_token_status());
user_dict->SetBoolean(kKeySignedIn, signed_in);
@@ -646,8 +652,10 @@ void SigninScreenHandler::SendUserList(bool animated) {
if (show_guest) {
// Add the Guest to the user list.
DictionaryValue* guest_dict = new DictionaryValue();
- guest_dict->SetString(kKeyName, l10n_util::GetStringUTF16(IDS_GUEST));
+ guest_dict->SetString(kKeyUsername, "");
guest_dict->SetString(kKeyEmailAddress, "");
+ guest_dict->SetString(kKeyDisplayName,
+ l10n_util::GetStringUTF16(IDS_GUEST));
guest_dict->SetBoolean(kKeyCanRemove, false);
guest_dict->SetInteger(kKeyOauthTokenStatus,
User::OAUTH_TOKEN_STATUS_UNKNOWN);

Powered by Google App Engine
This is Rietveld 408576698