Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/x64/debug-x64.cc

Issue 8773039: Clean up multi byte nop support on x64 to more closely match IA32. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/assembler-x64.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 // ----------------------------------- 257 // -----------------------------------
258 Generate_DebugBreakCallHelper(masm, rdi.bit(), 0, false); 258 Generate_DebugBreakCallHelper(masm, rdi.bit(), 0, false);
259 } 259 }
260 260
261 261
262 void Debug::GenerateSlot(MacroAssembler* masm) { 262 void Debug::GenerateSlot(MacroAssembler* masm) {
263 // Generate enough nop's to make space for a call instruction. 263 // Generate enough nop's to make space for a call instruction.
264 Label check_codesize; 264 Label check_codesize;
265 __ bind(&check_codesize); 265 __ bind(&check_codesize);
266 __ RecordDebugBreakSlot(); 266 __ RecordDebugBreakSlot();
267 for (int i = 0; i < Assembler::kDebugBreakSlotLength; i++) { 267 __ Nop(Assembler::kDebugBreakSlotLength);
268 __ nop();
269 }
270 ASSERT_EQ(Assembler::kDebugBreakSlotLength, 268 ASSERT_EQ(Assembler::kDebugBreakSlotLength,
271 masm->SizeOfCodeGeneratedSince(&check_codesize)); 269 masm->SizeOfCodeGeneratedSince(&check_codesize));
272 } 270 }
273 271
274 272
275 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) { 273 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) {
276 // In the places where a debug break slot is inserted no registers can contain 274 // In the places where a debug break slot is inserted no registers can contain
277 // object pointers. 275 // object pointers.
278 Generate_DebugBreakCallHelper(masm, 0, 0, true); 276 Generate_DebugBreakCallHelper(masm, 0, 0, true);
279 } 277 }
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 309
312 const bool Debug::kFrameDropperSupported = true; 310 const bool Debug::kFrameDropperSupported = true;
313 311
314 #undef __ 312 #undef __
315 313
316 #endif // ENABLE_DEBUGGER_SUPPORT 314 #endif // ENABLE_DEBUGGER_SUPPORT
317 315
318 } } // namespace v8::internal 316 } } // namespace v8::internal
319 317
320 #endif // V8_TARGET_ARCH_X64 318 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/assembler-x64.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698