Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 8773036: Make multi tests work with DartC. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reworking Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/testing/dart/test_runner.dart ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index fdb0d2443faac4af2be360f85cc47e3e754c91a1..7602989fe46c9fe79972c56ca4d711a9a7815416 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -187,7 +187,8 @@ class StandardTestSuite implements TestSuite {
Function createTestCase(String filename,
bool isNegative,
- [bool isNegativeIfChecked = false]) {
+ [bool isNegativeIfChecked = false,
+ bool enableFatalTypeErrors = false]) {
// Look up expectations in status files using a modified file path.
String pathSeparator = new Platform().pathSeparator();
String testName;
@@ -207,7 +208,9 @@ class StandardTestSuite implements TestSuite {
isNegative = isNegative ||
(configuration['checked'] && isNegativeIfChecked);
- var argumentLists = argumentListsFromFile(filename, optionsFromFile);
+ var argumentLists = argumentListsFromFile(filename,
+ optionsFromFile,
+ enableFatalTypeErrors);
for (var args in argumentLists) {
doTest(new TestCase(testName,
shellPath,
@@ -219,12 +222,13 @@ class StandardTestSuite implements TestSuite {
}
}
-
if (optionsFromFile['isMultitest']) {
+ bool supportsFatalTypeErrors = (configuration['component'] == 'dartc');
++activeMultitests;
DoMultitest(filename,
TestUtils.buildDir(configuration),
directoryPath,
+ supportsFatalTypeErrors,
createTestCase,
multitestDone);
} else {
@@ -250,9 +254,11 @@ class StandardTestSuite implements TestSuite {
}
List<List<String>> argumentListsFromFile(String filename,
- Map optionsFromFile) {
+ Map optionsFromFile,
+ bool enableFatalTypeErrors) {
List args = TestUtils.standardOptions(configuration);
args.addAll(additionalOptions());
+ if (enableFatalTypeErrors) args.add('--fatal-type-errors');
bool isMultitest = optionsFromFile["isMultitest"];
List<String> dartOptions = optionsFromFile["dartOptions"];
« tools/testing/dart/test_runner.dart ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698