Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issue 8773034: Clean up error handling and timestamp initialization for cloud policy. (Closed)

Created:
9 years ago by Mattias Nissler (ping if slow)
Modified:
9 years ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Visibility:
Public.

Description

Clean up error handling and timestamp initialization for cloud policy. BUG=chromium-os:23685 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M chrome/browser/policy/cloud_policy_controller.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/policy/device_policy_cache.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/policy/device_token_fetcher.cc View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Here's the thing. I tested it and it seems to be good.
9 years ago (2011-12-02 10:39:27 UTC) #1
Joao da Silva
LGTM! Nice cleanup on the state machines.
9 years ago (2011-12-02 11:01:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/8773034/1
9 years ago (2011-12-02 12:25:49 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-02 13:45:09 UTC) #4
Change committed as 112687

Powered by Google App Engine
This is Rietveld 408576698