Canonicalize TypeArguments.

runtime/vm/raw_object.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "vm/assert.h"
 #include "vm/globals.h"
 #include "vm/snapshot.h"
@@ skipping 317 matching lines @@
 class RawAbstractTypeArguments : public RawObject {
   RAW_HEAP_OBJECT_IMPLEMENTATION(AbstractTypeArguments);
 };
 
 
 class RawTypeArguments : public RawAbstractTypeArguments {
  private:
   RAW_HEAP_OBJECT_IMPLEMENTATION(TypeArguments);
 
   RawObject** from() {
     return reinterpret_cast<RawObject**>(&ptr()->length_);

[regis, 2011/12/05 23:16:35]

length_ needs to be changed if you keep a dart bool. But I would use a c++ bool
for is_canonical_.

[srdjan, 2011/12/06 17:24:15]

Removed Dart Bool, using C++ bool. I think length relates to types_ not to
length of the object.

   }
   RawSmi* length_;
+  RawBool* is_canonical_;

[regis, 2011/12/05 23:16:35]

Why a dart bool?

[srdjan, 2011/12/06 17:24:15]

Changed to C++ bool.

 
   // Variable length data follows here.
   RawAbstractType* types_[0];
   RawObject** to(intptr_t length) {
     return reinterpret_cast<RawObject**>(&ptr()->types_[length - 1]);
   }
 };
 
 
 class RawInstantiatedTypeArguments : public RawAbstractTypeArguments {
@@ skipping 504 matching lines @@
   intptr_t type_;  // Uninitialized, simple or complex.
   intptr_t flags_;  // Represents global/local, case insensitive, multiline.
 
   // Variable length data follows here.
   uint8_t data_[0];
 };
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_