Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: client/dom/scripts/dartgenerator.py

Issue 8773024: Mark frog DOMWindow as aliased with global scope. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/generated/src/frog/DOMWindow.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/dartgenerator.py
diff --git a/client/dom/scripts/dartgenerator.py b/client/dom/scripts/dartgenerator.py
index f93fdd7dcdda23ccb32f50fad851bab530f87cc6..90be5d4baf5b04f8b64a9dcd0c008d276d2017ed 100755
--- a/client/dom/scripts/dartgenerator.py
+++ b/client/dom/scripts/dartgenerator.py
@@ -1928,14 +1928,18 @@ class FrogInterfaceGenerator(object):
else:
constructor = ''
+ # Compiler needs to know window is aliased with global scope.
+ global_marker = '@' if interface_name == 'DOMWindow' else ''
+
(self._members_emitter, self._base_emitter) = self._dart_code.Emit(
'\n'
- 'class $CLASS$BASE native "*$CLASS" {\n'
+ 'class $CLASS$BASE native "$SPLAT*$CLASS" {\n'
'$CONSTRUCTOR$!MEMBERS'
'$!ADDITIONS'
'}\n',
CLASS=self._class_name, BASE=extends,
- INTERFACE=interface_name, CONSTRUCTOR=constructor)
+ INTERFACE=interface_name, CONSTRUCTOR=constructor,
+ SPLAT=global_marker)
if not base:
# Emit shared base functionality here as we have no common base type.
« no previous file with comments | « client/dom/generated/src/frog/DOMWindow.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698