Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 8773018: Initialize the CPU usage variable. (Closed)

Created:
9 years ago by brettw
Modified:
9 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, Alexander Potapenko, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Initialize the CPU usage variable. I'm not sure why it's causing valgrind errors, since the IPC system should always be writing the variable. But it's probably good practice to initialize it anyway. BUG=106067 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113408

Patch Set 1 #

Patch Set 2 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
9 years ago (2011-12-01 22:11:29 UTC) #1
yzshen1
lgtm
9 years ago (2011-12-01 22:15:43 UTC) #2
Timur Iskhodzhanov
Please look at http://codereview.chromium.org/8769040/
9 years ago (2011-12-02 14:53:31 UTC) #3
ulan
On 2011/12/02 14:53:31, Timur Iskhodzhanov wrote: > Please look at http://codereview.chromium.org/8769040/ The only difference between ...
9 years ago (2011-12-02 15:45:32 UTC) #4
jam
On 2011/12/02 15:45:32, ulan wrote: > On 2011/12/02 14:53:31, Timur Iskhodzhanov wrote: > > Please ...
9 years ago (2011-12-02 17:06:52 UTC) #5
brettw
I guess I don't care either way. Feel free to check in yours.
9 years ago (2011-12-02 21:38:22 UTC) #6
ulan
9 years ago (2011-12-07 16:17:45 UTC) #7
On 2011/12/02 21:38:22, brettw wrote:
> I guess I don't care either way. Feel free to check in yours.

brettw, could you please check in your version?

John's argument convinced me that 0 is better.

Powered by Google App Engine
This is Rietveld 408576698