Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 8773007: Don't call CancelPendingRequest for synchronously answered requests (Closed)

Created:
9 years ago by battre
Modified:
9 years ago
Reviewers:
Mark Mentovai, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Don't call CancelPendingRequest for synchronously answered requests BUG=106032 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/common/resource_dispatcher.cc View 4 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
battre
Please review. Thanks, Dominic
9 years ago (2011-12-01 13:06:56 UTC) #1
Mark Mentovai
This looks good to me, but I’m not an OWNER in this directory. http://src.chromium.org/svn/trunk/src/content/common/OWNERS
9 years ago (2011-12-01 19:37:54 UTC) #2
battre
+jam for OWNERS approval
9 years ago (2011-12-01 20:01:52 UTC) #3
jam
lgtm
9 years ago (2011-12-01 23:40:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8773007/1
9 years ago (2011-12-02 06:37:16 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-02 08:17:04 UTC) #6
Change committed as 112657

Powered by Google App Engine
This is Rietveld 408576698