Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: ui/base/accelerators/accelerator.cc

Issue 8773003: Implement Accelerator::GetShortcutText for non-Windows Aura. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/accelerators/accelerator.h" 5 #include "ui/base/accelerators/accelerator.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #elif defined(TOOLKIT_USES_GTK) 9 #elif defined(TOOLKIT_USES_GTK)
10 #include <gdk/gdk.h> 10 #include <gdk/gdk.h>
11 #endif 11 #endif
12 12
13 #include "base/i18n/rtl.h" 13 #include "base/i18n/rtl.h"
14 #include "base/logging.h" 14 #include "base/logging.h"
15 #include "base/string_util.h" 15 #include "base/string_util.h"
16 #include "base/utf_string_conversions.h" 16 #include "base/utf_string_conversions.h"
17 #include "grit/ui_strings.h" 17 #include "grit/ui_strings.h"
18 #include "ui/base/l10n/l10n_util.h" 18 #include "ui/base/l10n/l10n_util.h"
19 19
20 #if !defined(OS_WIN) && defined(USE_AURA)
21 #include "ui/base/keycodes/keyboard_code_conversion.h"
22 #endif
23
20 namespace ui { 24 namespace ui {
21 25
22 string16 Accelerator::GetShortcutText() const { 26 string16 Accelerator::GetShortcutText() const {
23 int string_id = 0; 27 int string_id = 0;
24 switch(key_code_) { 28 switch(key_code_) {
25 case ui::VKEY_TAB: 29 case ui::VKEY_TAB:
26 string_id = IDS_APP_TAB_KEY; 30 string_id = IDS_APP_TAB_KEY;
27 break; 31 break;
28 case ui::VKEY_RETURN: 32 case ui::VKEY_RETURN:
29 string_id = IDS_APP_ENTER_KEY; 33 string_id = IDS_APP_ENTER_KEY;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 // layouts have characters other than digits assigned in 80 // layouts have characters other than digits assigned in
77 // an unshifted mode (e.g. French AZERY layout has 'a with grave 81 // an unshifted mode (e.g. French AZERY layout has 'a with grave
78 // accent' for '0'). For display in the menu (e.g. Ctrl-0 for the 82 // accent' for '0'). For display in the menu (e.g. Ctrl-0 for the
79 // default zoom level), we leave VK_[0-9] alone without translation. 83 // default zoom level), we leave VK_[0-9] alone without translation.
80 wchar_t key; 84 wchar_t key;
81 if (key_code_ >= '0' && key_code_ <= '9') 85 if (key_code_ >= '0' && key_code_ <= '9')
82 key = key_code_; 86 key = key_code_;
83 else 87 else
84 key = LOWORD(::MapVirtualKeyW(key_code_, MAPVK_VK_TO_CHAR)); 88 key = LOWORD(::MapVirtualKeyW(key_code_, MAPVK_VK_TO_CHAR));
85 shortcut += key; 89 shortcut += key;
90 #elif defined(USE_AURA)
91 const uint16 c = GetCharacterFromKeyCode(key_code_, false);
92 if (c != 0) {
93 shortcut += static_cast<string16::value_type>(base::ToUpperASCII(c));
94 }
86 #elif defined(TOOLKIT_USES_GTK) 95 #elif defined(TOOLKIT_USES_GTK)
87 const gchar* name = NULL; 96 const gchar* name = NULL;
88 switch (key_code_) { 97 switch (key_code_) {
89 case ui::VKEY_OEM_2: 98 case ui::VKEY_OEM_2:
90 name = static_cast<const gchar*>("/"); 99 name = static_cast<const gchar*>("/");
91 break; 100 break;
92 default: 101 default:
93 name = gdk_keyval_name(gdk_keyval_to_lower(key_code_)); 102 name = gdk_keyval_name(gdk_keyval_to_lower(key_code_));
94 break; 103 break;
95 } 104 }
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 163
155 // Subtracting the size of the shortcut key and 1 for the '+' sign. 164 // Subtracting the size of the shortcut key and 1 for the '+' sign.
156 shortcut_rtl.append(shortcut, 0, shortcut.length() - key_length - 1); 165 shortcut_rtl.append(shortcut, 0, shortcut.length() - key_length - 1);
157 shortcut.swap(shortcut_rtl); 166 shortcut.swap(shortcut_rtl);
158 } 167 }
159 168
160 return shortcut; 169 return shortcut;
161 } 170 }
162 171
163 } // namespace ui 172 } // namespace ui
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698