[Sync] Convert syncable/ directory to ModelEnumSet

[Sync] Convert syncable/ directory to ModelEnumSet

First in a series of patches to replace ModelType{Bit,}Set with
ModelEnumSet (which will then be renamed to ModelTypeSet).

BUG=79970
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113286

[akalin, 2011-12-03 03:12:49]

+zea for review

most (but not all) changes are mechanical.

[akalin, 2011-12-06 18:43:48]

ping!

[Nicolas Zea, 2011-12-06 19:31:22]

LGTM with 1 nit and green bots.

http://codereview.chromium.org/8772074/diff/2001/chrome/browser/sync/internal...
File chrome/browser/sync/internal_api/sync_manager.cc (right):

http://codereview.chromium.org/8772074/diff/2001/chrome/browser/sync/internal...
chrome/browser/sync/internal_api/sync_manager.cc:1387: for (int i =
syncable::FIRST_REAL_MODEL_TYPE;
Rewrite to iterate over ModelEnumSet::All(), and replace type with it.Get()?

[Nicolas Zea, 2011-12-06 19:40:16]

http://codereview.chromium.org/8772074/diff/2001/chrome/browser/sync/internal...
File chrome/browser/sync/internal_api/sync_manager.cc (right):

http://codereview.chromium.org/8772074/diff/2001/chrome/browser/sync/internal...
chrome/browser/sync/internal_api/sync_manager.cc:1387: for (int i =
syncable::FIRST_REAL_MODEL_TYPE;
On 2011/12/06 19:31:22, nzea wrote:
> Rewrite to iterate over ModelEnumSet::All(), and replace type with it.Get()?

Actually, disregard, I forgot All() is a static, and you need an object to
iterate over. Not much real advantage

[akalin, 2011-12-06 19:48:07]

> Actually, disregard, I forgot All() is a static, and you need an object to
> iterate over. Not much real advantage

Yeah.  I was thinking of having a similar EnumMap class, which would make that
iteration a bit cleaner.  But that's down the line.

[commit-bot: I haz the power, 2011-12-06 21:50:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/8772074/16001

[commit-bot: I haz the power, 2011-12-06 23:37:37]

Change committed as 113286