[Sync] Add new EnumSet class representing a set of enum values

[Sync] Add new EnumSet class representing a set of enum values

This will eventually replace ModelType{Bit,}Set.

BUG=79970
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113147

[akalin, 2011-12-03 03:05:48]

+zea for review

[Nicolas Zea, 2011-12-05 22:39:22]

http://codereview.chromium.org/8772073/diff/1/chrome/browser/sync/util/enum_s...
File chrome/browser/sync/util/enum_set.h (right):

http://codereview.chromium.org/8772073/diff/1/chrome/browser/sync/util/enum_s...
chrome/browser/sync/util/enum_set.h:195: EnumSet Union(EnumSet other) const
WARN_UNUSED_RESULT {
Although it can't be used as such, these methods still look like they might
modify the object itself. What do you think about having these method be
classless and friended, like operators:
 EnumSet x = EnumUnion(lhs, rhs)

[akalin, 2011-12-05 23:47:16]

On 2011/12/05 22:39:22, nzea wrote:
>
http://codereview.chromium.org/8772073/diff/1/chrome/browser/sync/util/enum_s...
> File chrome/browser/sync/util/enum_set.h (right):
> 
>
http://codereview.chromium.org/8772073/diff/1/chrome/browser/sync/util/enum_s...
> chrome/browser/sync/util/enum_set.h:195: EnumSet Union(EnumSet other) const
> WARN_UNUSED_RESULT {
> Although it can't be used as such, these methods still look like they might
> modify the object itself. What do you think about having these method be
> classless and friended, like operators:
>  EnumSet x = EnumUnion(lhs, rhs)

This might work with argument-dependent lookup.  I'll look into it.

[akalin, 2011-12-06 00:12:45]

Comments addressed, PTAL.

[Nicolas Zea, 2011-12-06 00:18:09]

LGTM

[commit-bot: I haz the power, 2011-12-06 02:55:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/8772073/5001

[commit-bot: I haz the power, 2011-12-06 07:34:18]

Change committed as 113147