Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: frog/member.dart

Issue 8772070: Check constness of default args (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« frog/evaluator.dart ('K') | « frog/evaluator.dart ('k') | frog/minfrog » ('j') | tests/language/src/ConstOptionalArgsNegativeTest.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member.dart
diff --git a/frog/member.dart b/frog/member.dart
index 6874bf34957cded349fcaeff54b3c919bbb37bd0..3b45ba2e4e4196b943c295445d874d78e0a53f83 100644
--- a/frog/member.dart
+++ b/frog/member.dart
@@ -60,6 +60,9 @@ class Parameter {
context = new MethodGenerator(method, null);
}
value = definition.value.visit(context);
+ if (!value.isConst) {
+ world.error('default arguments must be constant', value.span);
jimhug 2011/12/06 16:23:39 Pet peeve: 'default parameter values must be const
+ }
value = value.convertTo(context, type, definition.value);
}
« frog/evaluator.dart ('K') | « frog/evaluator.dart ('k') | frog/minfrog » ('j') | tests/language/src/ConstOptionalArgsNegativeTest.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698