Issue 8772065: The chromoting client logs a session-close initiated by the client itself.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8772065: The chromoting client logs a session-close initiated by the client itself. (Closed)

Created:
9 years ago by simonmorris

Modified:
9 years ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

The chromoting client logs a session-close that was initiated by the client itself. BUG=106208 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112819

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add an explanatory comment. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	remoting/webapp/me2mom/client_session.js	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jamie

lgtm with one comment. http://codereview.chromium.org/8772065/diff/1/remoting/webapp/me2mom/client_session.js File remoting/webapp/me2mom/client_session.js (right): http://codereview.chromium.org/8772065/diff/1/remoting/webapp/me2mom/client_session.js#newcode207 remoting/webapp/me2mom/client_session.js:207: remoting.ClientSession.ConnectionError.NONE); Please add a comment ...

9 years ago (2011-12-02 23:48:25 UTC) #2

simonmorris

9 years ago (2011-12-02 23:54:51 UTC) #3

FYI

http://codereview.chromium.org/8772065/diff/1/remoting/webapp/me2mom/client_s...
File remoting/webapp/me2mom/client_session.js (right):

http://codereview.chromium.org/8772065/diff/1/remoting/webapp/me2mom/client_s...
remoting/webapp/me2mom/client_session.js:207:
remoting.ClientSession.ConnectionError.NONE);
On 2011/12/02 23:48:26, Jamie wrote:
> Please add a comment explaining that we won't get a state change so we log it
> explicitly.

Done.

Expand Messages | Collapse Messages