Refactor window frame painting into a window background class

Refactor window frame painting into a window background class

We currently have several copies of the code that draws the non-client frame area of windows, including OpaqueBrowserFrameView, ConstrainedWindowFrameViews, CustomFrameView, and others.  We need yet another version for Aura.  Rather than make another copy I'm trying to refactor out the common drawing code.  This is step 1, creating a views::FrameBackground class and using it in two cases.

BUG=102797
TEST=visual, try normal frame, install a theme, open a constrained window like cookie > Show cookies and other site data, open a popup from popuptest.com


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113913

[James Cook, 2011-12-03 00:42:08]

Ben, this isn't ready for a real review, but could you take a quick look at
frame_background.h/cc and let me know if this looks like a reasonable direction?
 I end up having to push a fair amount of data into the background on each paint
cycle, but it seems to work and match the earlier behavior.

[James Cook, 2011-12-06 19:38:48]

On 2011/12/03 00:42:08, James Cook (Chromium) wrote:
> Ben, this isn't ready for a real review, but could you take a quick look at
> frame_background.h/cc and let me know if this looks like a reasonable
direction?
>  I end up having to push a fair amount of data into the background on each
paint
> cycle, but it seems to work and match the earlier behavior.

Ping?

[Ben Goodger (Google), 2011-12-06 21:11:08]

like the direction! clean away

[James Cook, 2011-12-07 18:51:45]

Ben, PTAL.  This is step one of what will probably be two or three CLs to
completely convert things to using FrameBackground.  I intentionally didn't make
it a views::Background because it has multiple paint modes (Restored vs.
Maximized for now, maybe one or two more later).  I visually checked it on
Windows, Linux, Linux Aura, Linux ChromeOS, and Linux ChromeOS Aura.  I've been
testing with browser windows, popup windows, JavaScript alerts, and the "Show
cookies" dialog, with both the standard theme and a custom theme ("Paint
Chips").  I think that covers the classes I modified.

[James Cook, 2011-12-09 17:43:43]

On 2011/12/07 18:51:45, James Cook (Chromium) wrote:
> Ben, PTAL.  This is step one of what will probably be two or three CLs to
> completely convert things to using FrameBackground.  I intentionally didn't
make
> it a views::Background because it has multiple paint modes (Restored vs.
> Maximized for now, maybe one or two more later).  I visually checked it on
> Windows, Linux, Linux Aura, Linux ChromeOS, and Linux ChromeOS Aura.  I've
been
> testing with browser windows, popup windows, JavaScript alerts, and the "Show
> cookies" dialog, with both the standard theme and a custom theme ("Paint
> Chips").  I think that covers the classes I modified.

Ping Ben?

[Ben Goodger (Google), 2011-12-09 22:42:56]

This is a great change.

LGTM.

[commit-bot: I haz the power, 2011-12-09 23:56:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/8772060/4011

[commit-bot: I haz the power, 2011-12-10 01:24:48]

Change committed as 113913