Use Google Plus API to get profile information

chrome/browser/profiles/profile_downloader.h

Index: chrome/browser/profiles/profile_downloader.h
diff --git a/chrome/browser/profiles/profile_downloader.h b/chrome/browser/profiles/profile_downloader.h
index 4e15a47fa5d7ad215477463bb74f116a6c16c575..d4c72e3d75ade7a276b682e3b76951a3824549d7 100644
--- a/chrome/browser/profiles/profile_downloader.h
+++ b/chrome/browser/profiles/profile_downloader.h
@@ -61,6 +61,13 @@ class ProfileDownloader : public content::URLFetcherDelegate,
   // when the picture status is PICTURE_SUCCESS.
   virtual std::string GetProfilePictureURL() const;
 
+  // Parses the entry response and gets the name and and profile image URL.
+  // Returns false to indicate a parsing error.
+  static bool GetProfileNameAndImageURL(const std::string& data,

[Ivan Korotkov, 2011/12/04 15:08:52]

Please document what |data| is (entry response is vague without context).

[sail, 2011/12/05 19:26:12]

Done.

+                                        string16* nick_name,
+                                        std::string* url,
+                                        int image_size);

[Ivan Korotkov, 2011/12/04 15:08:52]

if this is public for testing only, consider declaring class
ProfileDownloaderTest as friend instead (a common practice if you search for
"friend\ class\ .*Test").

[sail, 2011/12/05 19:26:12]

Done.

+
  private:
   // Overriden from content::URLFetcherDelegate:
   virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE;
@@ -79,12 +86,6 @@ class ProfileDownloader : public content::URLFetcherDelegate,
   virtual void OnGetTokenSuccess(const std::string& access_token) OVERRIDE;
   virtual void OnGetTokenFailure(const GoogleServiceAuthError& error) OVERRIDE;
 
-  // Parses the entry response from Picasa and gets the nick name and
-  // and profile image URL. Returns false to indicate a parsing error.
-  bool GetProfileNickNameAndImageURL(const std::string& data,
-                                     string16* nick_name,
-                                     std::string* url) const;
-
   // Returns true if the image url is url of the default profile picture.
   bool IsDefaultProfileImageURL(const std::string& url) const;