Issue 8772046: Make input boxes on history and downloads look nice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8772046: Make input boxes on history and downloads look nice. (Closed)

Created:
9 years ago by Patrick Dubroy

Modified:
9 years ago

Reviewers:
benjhayden, arv (Not doing code reviews), Evan Stade

CC:
chromium-reviews, asanka, arv (Not doing code reviews), Randy Smith (Not in Mondays)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make input boxes on history and downloads look nice. Also clean up some unnecessary complexity in history HTML, and move history-specific CSS from old_webui.css to history.css. BUG=None. TEST=Manual test of functionality on history and downloads pages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113056

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -22 lines)			Patch
M	chrome/browser/resources/downloads.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/history.css	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/history.html	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/old_webui.css	View	2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Patrick Dubroy

Evan, can you please review? The search boxes on history & downloads don't really fit ...

9 years ago (2011-12-02 16:24:57 UTC) #1

Patrick Dubroy

+arv for review; just hoping this can get reviewed so I can land before branch.

9 years ago (2011-12-02 23:36:23 UTC) #2

commit-bot: I haz the power

9 years ago (2011-12-05 22:08:39 UTC) #6

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dubroy@chromium.org/8772046/1

Expand Messages | Collapse Messages