Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: content/browser/tab_contents/tab_contents_delegate.cc

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents_delegate.cc
diff --git a/content/browser/tab_contents/tab_contents_delegate.cc b/content/browser/tab_contents/tab_contents_delegate.cc
index 4b36bc6a8d9740f286dbbd6534204dbeb9805d68..e8ca205142606447d91cc9391e5eb4a0baf634d9 100644
--- a/content/browser/tab_contents/tab_contents_delegate.cc
+++ b/content/browser/tab_contents/tab_contents_delegate.cc
@@ -17,17 +17,6 @@
TabContentsDelegate::TabContentsDelegate() {
}
-TabContents* TabContentsDelegate::OpenURLFromTab(
- TabContents* source,
- const GURL& url,
- const GURL& referrer,
- WindowOpenDisposition disposition,
- content::PageTransition transition) {
- return OpenURLFromTab(source,
- OpenURLParams(url, referrer, disposition, transition,
- false));
-}
-
TabContents* TabContentsDelegate::OpenURLFromTab(TabContents* source,
const OpenURLParams& params) {
return NULL;
@@ -160,11 +149,9 @@ void TabContentsDelegate::ViewSourceForTab(TabContents* source,
// it with proper implementation.
GURL url = GURL(chrome::kViewSourceScheme + std::string(":") +
page_url.spec());
- OpenURLFromTab(source,
- url,
- GURL(),
- NEW_FOREGROUND_TAB,
- content::PAGE_TRANSITION_LINK);
+ OpenURLFromTab(source, OpenURLParams(url, content::Referrer(),
+ NEW_FOREGROUND_TAB,
+ content::PAGE_TRANSITION_LINK, false));
}
void TabContentsDelegate::ViewSourceForFrame(TabContents* source,
@@ -173,11 +160,9 @@ void TabContentsDelegate::ViewSourceForFrame(TabContents* source,
// Same as ViewSourceForTab, but for given subframe.
GURL url = GURL(chrome::kViewSourceScheme + std::string(":") +
frame_url.spec());
- OpenURLFromTab(source,
- url,
- GURL(),
- NEW_FOREGROUND_TAB,
- content::PAGE_TRANSITION_LINK);
+ OpenURLFromTab(source, OpenURLParams(url, content::Referrer(),
+ NEW_FOREGROUND_TAB,
+ content::PAGE_TRANSITION_LINK, false));
}
bool TabContentsDelegate::PreHandleKeyboardEvent(
« no previous file with comments | « content/browser/tab_contents/tab_contents_delegate.h ('k') | content/browser/tab_contents/tab_contents_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698