Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tab_contents/tab_contents.h ('k') | content/browser/tab_contents/tab_contents_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index b9fba7064782c46f9bdb745ab755ec6455d2fc4f..23abcceda8b2e30ebb7c8b0e363b069487b32e86 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -573,8 +573,10 @@ TabContents* TabContents::OpenURL(const GURL& url,
const GURL& referrer,
WindowOpenDisposition disposition,
content::PageTransition transition) {
- return OpenURL(OpenURLParams(url, referrer, disposition, transition,
- false));
+ // For specifying a referrer, use the version of OpenURL taking OpenURLParams.
+ DCHECK(referrer.is_empty());
+ return OpenURL(OpenURLParams(url, content::Referrer(), disposition,
+ transition, false));
}
TabContents* TabContents::OpenURL(const OpenURLParams& params) {
@@ -1745,7 +1747,7 @@ void TabContents::DocumentOnLoadCompletedInMainFrame(
}
void TabContents::RequestOpenURL(const GURL& url,
- const GURL& referrer,
+ const content::Referrer& referrer,
WindowOpenDisposition disposition,
int64 source_frame_id) {
TabContents* new_contents = NULL;
« no previous file with comments | « content/browser/tab_contents/tab_contents.h ('k') | content/browser/tab_contents/tab_contents_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698