Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4057)

Unified Diff: chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc
diff --git a/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc b/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc
index 9a5f22eee83c1122f901679eb21e4dbfa82042c5..b6360243f9fe51f815593b20d8de23d86767d5c2 100644
--- a/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc
+++ b/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc
@@ -72,8 +72,8 @@ TEST_F(HtmlDialogTabContentsDelegateTest, DoNothingMethodsTest) {
TEST_F(HtmlDialogTabContentsDelegateTest, OpenURLFromTabTest) {
test_tab_contents_delegate_->OpenURLFromTab(
- NULL, GURL(chrome::kAboutBlankURL), GURL(),
- NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK);
+ NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), content::Referrer(),
+ NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false));
// This should create a new foreground tab in the existing browser.
EXPECT_EQ(1, browser()->tab_count());
EXPECT_EQ(1U, BrowserList::size());
@@ -95,8 +95,8 @@ TEST_F(HtmlDialogTabContentsDelegateTest, DetachTest) {
EXPECT_EQ(NULL, test_tab_contents_delegate_->profile());
// Now, none of the following calls should do anything.
test_tab_contents_delegate_->OpenURLFromTab(
- NULL, GURL(chrome::kAboutBlankURL), GURL(),
- NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK);
+ NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), content::Referrer(),
+ NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false));
test_tab_contents_delegate_->AddNewContents(NULL, NULL, NEW_FOREGROUND_TAB,
gfx::Rect(), false);
EXPECT_EQ(0, browser()->tab_count());
« no previous file with comments | « chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc ('k') | chrome/browser/ui/webui/web_ui_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698