chrome/browser/plugin_observer.cc - Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugin_observer.cc

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/plugin_observer.cc

diff --git a/chrome/browser/plugin_observer.cc b/chrome/browser/plugin_observer.cc

index 62562a4bfb1c44ae77bcd787b4b19eaad6fc7c93..b01c08379a980c12f120dbfba5307e5e5ced6dc3 100644

--- a/chrome/browser/plugin_observer.cc

+++ b/chrome/browser/plugin_observer.cc

@@ -350,8 +350,11 @@ void PluginObserver::DidNotFindMissingPlugin(int placeholder_id,

void PluginObserver::InstallMissingPlugin(PluginInstaller* installer) {

if (installer->url_for_display()) {

- tab_contents()->OpenURL(installer->plugin_url(), tab_contents()->GetURL(),

- NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_TYPED);

+ tab_contents()->OpenURL(OpenURLParams(

+ installer->plugin_url(),

+ content::Referrer(tab_contents()->GetURL(),

+ WebKit::WebReferrerPolicyDefault),

+ NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_TYPED, false));

} else {

NOTIMPLEMENTED();

}