Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: chrome/browser/debugger/devtools_window.cc

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/debugger/devtools_window.h ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_window.cc
diff --git a/chrome/browser/debugger/devtools_window.cc b/chrome/browser/debugger/devtools_window.cc
index 020a242271bbe92454c09622be5b70df5c021c3e..9d1dd6b0a65f553c3a4d8e17ad1f427a9e16f925 100644
--- a/chrome/browser/debugger/devtools_window.cc
+++ b/chrome/browser/debugger/devtools_window.cc
@@ -163,7 +163,7 @@ DevToolsWindow* DevToolsWindow::Create(
content::BINDINGS_POLICY_WEB_UI);
tab_contents->controller().LoadURL(
GetDevToolsUrl(profile, docked, shared_worker_frontend),
- GURL(),
+ content::Referrer(),
content::PAGE_TRANSITION_START_PAGE,
std::string());
return new DevToolsWindow(tab_contents, profile, inspected_rvh, docked);
@@ -429,18 +429,6 @@ void DevToolsWindow::AddDevToolsExtensionsToClient() {
CallClientFunction(ASCIIToUTF16("WebInspector.addExtensions"), results);
}
-// TODO(adriansc): Remove this method once refactoring changed all call sites.
-TabContents* DevToolsWindow::OpenURLFromTab(
- TabContents* source,
- const GURL& url,
- const GURL& referrer,
- WindowOpenDisposition disposition,
- content::PageTransition transition) {
- return OpenURLFromTab(source,
- OpenURLParams(url, referrer, disposition, transition,
- false));
-}
-
TabContents* DevToolsWindow::OpenURLFromTab(TabContents* source,
const OpenURLParams& params) {
if (inspected_tab_) {
« no previous file with comments | « chrome/browser/debugger/devtools_window.h ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698