chrome/browser/automation/testing_automation_provider.cc - Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/testing_automation_provider.cc

diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc

index 3f9c93a4573a6bcb4761dd7a4c9dc82e0d486bec..985d9265f522bfd3c14c5a5b426d9d2f76635fd7 100644

--- a/chrome/browser/automation/testing_automation_provider.cc

+++ b/chrome/browser/automation/testing_automation_provider.cc

@@ -5921,9 +5921,9 @@ void TestingAutomationProvider::NavigateToURL(

new NavigationNotificationObserver(

&tab_contents->controller(), this, reply_message,

navigation_count, false, true);

- browser->OpenURLFromTab(

- tab_contents, GURL(url), GURL(), CURRENT_TAB,

- content::PAGE_TRANSITION_TYPED);

+ browser->OpenURLFromTab(tab_contents, OpenURLParams(

+ GURL(url), content::Referrer(), CURRENT_TAB,

+ content::PAGE_TRANSITION_TYPED, false));

}

void TestingAutomationProvider::ExecuteJavascriptJSON(