Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 8772035: Fix other notify of NOTIFICATION_HTML_DIALOG_SHOWN to pass the RenderViewHost. (Closed)

Created:
9 years ago by Sheridan Rawlins
Modified:
9 years ago
Reviewers:
flackr, oshima
CC:
chromium-reviews, Paweł Hajdan Jr., Rick Byers
Visibility:
Public.

Description

Fix other notify of NOTIFICATION_HTML_DIALOG_SHOWN to pass the RenderViewHost. R= oshima@chromium.org, flackr@chromium.org BUG=105952 TEST=CertificateViewerUITest*.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/ui/webui/constrained_html_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/certificate_viewer_dialog_test.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sheridan Rawlins
9 years ago (2011-12-02 05:04:19 UTC) #1
flackr
lgtm
9 years ago (2011-12-02 05:08:20 UTC) #2
oshima
rubber-stamp LGTM thank you for fix!
9 years ago (2011-12-02 05:50:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/8772035/1
9 years ago (2011-12-02 06:00:24 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-02 07:59:41 UTC) #5
Change committed as 112654

Powered by Google App Engine
This is Rietveld 408576698