Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 8772034: Make clang_load and clang_add_plugin independent. (Closed)

Created:
9 years ago by Nico
Modified:
9 years ago
Reviewers:
dcheng
CC:
chromium-reviews
Visibility:
Public.

Description

Make clang_load and clang_add_plugin independent. BUG=none TEST=GYP_DEFINES=clang_add_plugin=foo build/gyp_chromium adds a parameter Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/common.gypi View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
9 years ago (2011-12-02 02:28:13 UTC) #1
dcheng
lgtm
9 years ago (2011-12-02 02:28:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8772034/1
9 years ago (2011-12-02 02:32:39 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-02 03:41:55 UTC) #4
Change committed as 112630

Powered by Google App Engine
This is Rietveld 408576698