Reunite PanelStrip::AddPanel and its internals.

chrome/browser/ui/panels/panel_strip.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_strip.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 66 matching lines @@
   if (panels_.empty() || new_area.width() == old_area.width())
     return;
 
   if (new_area.width() < old_area.width())
     Rearrange();
   else
     MovePanelsFromOverflowIfNeeded();
 }
 
 void PanelStrip::AddPanel(Panel* panel) {
-  if (panel->initialized())
-    AddExistingPanel(panel);
-  else
-    AddNewPanel(panel);
-  panels_.push_back(panel);
-}
+  DCHECK_EQ(Panel::EXPANDED, panel->expansion_state());

[jianli, 2011/12/02 01:56:38]

This might not be true if |panel| is overflow panel.

[jennb, 2011/12/02 02:20:37]

Removed check for now as your patch will have logic for this.

 
-void PanelStrip::AddNewPanel(Panel* panel) {
-  DCHECK(!panel->initialized());
-
+  // Always update limits, even for exiting panels, in case the maximums changed
+  // while panel was out of the strip.
   int max_panel_width = GetMaxPanelWidth();
   int max_panel_height = GetMaxPanelHeight();
   panel->SetSizeRange(gfx::Size(kPanelMinWidth, kPanelMinHeight),
                       gfx::Size(max_panel_width, max_panel_height));
 
   gfx::Size restored_size = panel->restored_size();
   int height = restored_size.height();
   int width = restored_size.width();
 
-  if (height == 0 && width == 0) {
-    // Auto resizable is enabled only if no initial size is provided.
-    panel->SetAutoResizable(true);
+  if (panel->initialized()) {
+    // Bump panels in the strip to make room for this panel.
+    int x;
+    while ((x = GetRightMostAvailablePosition() - width) < display_area_.x()) {
+      DCHECK(!panels_.empty());
+      MovePanelToOverflow(panels_.back(), false);
+    }
+    int y = display_area_.bottom() - height;
+    panel->SetPanelBounds(gfx::Rect(x, y, width, height));
   } else {
-    if (height == 0)
-      height = width / kPanelDefaultWidthToHeightRatio;
-    if (width == 0)
-      width = height * kPanelDefaultWidthToHeightRatio;
+    // Initialize the newly created panel. Does not bump any panels from strip.
+    if (height == 0 && width == 0) {
+      // Auto resizable is enabled only if no initial size is provided.
+      panel->SetAutoResizable(true);
+    } else {
+      if (height == 0)
+        height = width / kPanelDefaultWidthToHeightRatio;
+      if (width == 0)
+        width = height * kPanelDefaultWidthToHeightRatio;
+    }
+
+    // Constrain sizes to limits.
+    if (width < kPanelMinWidth)
+      width = kPanelMinWidth;
+    else if (width > max_panel_width)
+      width = max_panel_width;
+
+    if (height < kPanelMinHeight)
+      height = kPanelMinHeight;
+    else if (height > max_panel_height)
+      height = max_panel_height;
+
+    panel->set_restored_size(gfx::Size(width, height));
+    int x = GetRightMostAvailablePosition() - width;
+    int y = display_area_.bottom() - height;
+
+    // Keep panel visible in the strip even if overlap would occur.
+    // Panel is moved to overflow from the strip after a delay.
+    if (x < display_area_.x()) {
+      x = display_area_.x();
+      MessageLoop::current()->PostDelayedTask(
+          FROM_HERE,
+          base::Bind(&PanelStrip::MovePanelToOverflow,
+                     overflow_action_factory_.GetWeakPtr(),

[dcheng, 2011/12/02 01:29:20]

It may be better to remove the WeakPtrFactory for now since we don't need
cancellation semantics.

[jennb, 2011/12/02 02:20:37]

Done.

+                     panel,
+                     true),  // new panel
+          kMoveNewPanelToOverflowDelayMilliseconds);

[jianli, 2011/12/02 01:56:38]

Can you check remove_delays_for_testing_ here and use 0 for this case?

[jennb, 2011/12/02 02:20:37]

Done.

+    }
+    panel->Initialize(gfx::Rect(x, y, width, height));
   }
 
-  // Constrain sizes to limits.
-  if (width < kPanelMinWidth)
-    width = kPanelMinWidth;
-  else if (width > max_panel_width)
-    width = max_panel_width;
-
-  if (height < kPanelMinHeight)
-    height = kPanelMinHeight;
-  else if (height > max_panel_height)
-    height = max_panel_height;
-  panel->set_restored_size(gfx::Size(width, height));
-
-  // Layout the new panel.
-  int y = display_area_.bottom() - height;
-  int x = GetRightMostAvailablePosition() - width;
-
-  // Keep panel visible in the strip even if overlap would occur.
-  // Panel is moved to overflow from the strip after a delay.
-  if (x < display_area_.x()) {
-    x = display_area_.x();
-    MessageLoop::current()->PostDelayedTask(
-        FROM_HERE,
-        base::Bind(&PanelStrip::MovePanelToOverflow,
-                   overflow_action_factory_.GetWeakPtr(),
-                   panel,
-                   true),  // new panel
-        kMoveNewPanelToOverflowDelayMilliseconds);
-  }
-  panel->Initialize(gfx::Rect(x, y, width, height));
-}
-
-void PanelStrip::AddExistingPanel(Panel* panel) {
-  gfx::Size restored_size = panel->restored_size();
-  int height = restored_size.height();
-  int width = restored_size.width();
-  int x;
-  while ((x = GetRightMostAvailablePosition() - width) < display_area_.x()) {
-    DCHECK(!panels_.empty());
-    MovePanelToOverflow(panels_.back(), false);
-  }
-  int y = display_area_.bottom() - height;
-  panel->SetPanelBounds(gfx::Rect(x, y, width, height));
+  panels_.push_back(panel);
 }
 
 int PanelStrip::GetMaxPanelWidth() const {
   return static_cast<int>(display_area_.width() * kPanelMaxWidthFactor);
 }
 
 int PanelStrip::GetMaxPanelHeight() const {
   return display_area_.height();
 }
 
@@ skipping 460 matching lines @@
 
   // Start from the bottom to avoid reshuffling.
   for (Panels::reverse_iterator iter = panels_copy.rbegin();
        iter != panels_copy.rend(); ++iter)
     (*iter)->Close();
 }
 
 bool PanelStrip::is_dragging_panel() const {
   return dragging_panel_index_ != kInvalidPanelIndex;
 }