Issue 8772027: Convert file ref private to use new registration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8772027: Convert file ref private to use new registration. (Closed)

Created:
9 years ago by brettw

Modified:
9 years ago

Reviewers:
Josh Horwich

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert file ref private to use new registration. This removes some manual registration code. It should also make FileRef private work in process, it didn't look like it was being registered for in-process use before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112740

Patch Set 1 #

Patch Set 2 : Add missing include #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -17 lines)			Patch
M	ppapi/proxy/interface_list.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppb_file_ref_proxy.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_file_ref_proxy.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	ppapi/thunk/interfaces_ppb_private.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/thunk/thunk.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2011/12/01 23:46:28, brettw wrote:

LGTM

Expand Messages | Collapse Messages